Skip to content

[DependencyScanning] Avoid extra cc1 arg round-trip to speed up bridging #81454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[DependencyScanning] Avoid extra cc1 arg round-trip to speed up bridging #81454

wants to merge 1 commit into from

Conversation

cachemeifyoucan
Copy link
Contributor

@cachemeifyoucan cachemeifyoucan commented May 12, 2025 •
edited
Loading

Use the underlying compiler invocation inside module scanning result to speed up the clang module dependency bridging. This avoids converting cc1 arguments to compiler invocation and back, just to modify the cc1 arguments needed for building PCM using swift-frontend.

rdar://151705822

@cachemeifyoucan
Copy link
Contributor Author

Please test with following PR:
swiftlang/llvm-project#10667

@swift-ci please smoke test

@cachemeifyoucan cachemeifyoucan force-pushed the clang-scanner-invocation-callback branch from cc78976 to 482f194 Compare May 13, 2025 22:59
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

@cachemeifyoucan
Copy link
Contributor Author

Please test with following PR:
swiftlang/llvm-project#10667

@swift-ci please smoke test

@cachemeifyoucan cachemeifyoucan force-pushed the clang-scanner-invocation-callback branch from 482f194 to 0aba426 Compare May 14, 2025 23:06
@cachemeifyoucan cachemeifyoucan marked this pull request as ready for review May 14, 2025 23:08
@cachemeifyoucan
Copy link
Contributor Author

Please test with following PR:
swiftlang/llvm-project#10667

@swift-ci please smoke test

@cachemeifyoucan cachemeifyoucan force-pushed the clang-scanner-invocation-callback branch from 0aba426 to 8072d19 Compare May 15, 2025 21:10
@cachemeifyoucan
Copy link
Contributor Author

Please test with following PR:
swiftlang/llvm-project#10667

@swift-ci please smoke test

@cachemeifyoucan
Copy link
Contributor Author

Please test with following PR:
swiftlang/llvm-project#10667

@swift-ci please smoke test macOS platform

1 similar comment
@cachemeifyoucan
Copy link
Contributor Author

Please test with following PR:
swiftlang/llvm-project#10667

@swift-ci please smoke test macOS platform

@cachemeifyoucan
[DependencyScanning] Avoid extra cc1 arg round-trip to speed up bridging
391446d 
Use the underlying compiler invocation inside module scanning result to
speed up the clang module dependency bridging. This avoids converting
cc1 arguments to compiler invocation and back, just to modify the cc1
arguments needed for building PCM using swift-frontend.

rdar://151705822
@cachemeifyoucan cachemeifyoucan force-pushed the clang-scanner-invocation-callback branch from 8072d19 to 391446d Compare May 20, 2025 16:55
@cachemeifyoucan
Copy link
Contributor Author

Please test with following PR:
swiftlang/llvm-project#10667

@swift-ci please smoke test macOS platform

@cachemeifyoucan
Copy link
Contributor Author

Please test with following PR:
swiftlang/llvm-project#10667

@swift-ci please smoke test

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

@cachemeifyoucan cachemeifyoucan mentioned this pull request May 22, 2025
Open
@cachemeifyoucan
Copy link
Contributor Author

ping

jansvoboda11
jansvoboda11 approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor

@jansvoboda11 jansvoboda11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think the PR title needs updating, and I'd also like for someone more familiar with the Swift side to take a look.

@cachemeifyoucan cachemeifyoucan changed the title [DependencyScanning] Use clang scanner callback to speed up bridging [DependencyScanning] Avoid extra cc1 arg round-trip to speed up bridging May 22, 2025
@cachemeifyoucan
Copy link
Contributor Author

Title and message updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansvoboda11 jansvoboda11 jansvoboda11 approved these changes

@artemcm artemcm Awaiting requested review from artemcm artemcm is a code owner

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

@egorzhdan egorzhdan Awaiting requested review from egorzhdan egorzhdan is a code owner

@beccadax beccadax Awaiting requested review from beccadax beccadax is a code owner

@ian-twilightcoder ian-twilightcoder Awaiting requested review from ian-twilightcoder ian-twilightcoder is a code owner

@Xazax-hun Xazax-hun Awaiting requested review from Xazax-hun Xazax-hun is a code owner

@j-hui j-hui Awaiting requested review from j-hui j-hui is a code owner

@fahadnayyar fahadnayyar Awaiting requested review from fahadnayyar fahadnayyar is a code owner

@susmonteiro susmonteiro Awaiting requested review from susmonteiro susmonteiro is a code owner

@qiongsiwu qiongsiwu Awaiting requested review from qiongsiwu

@benlangmuir benlangmuir Awaiting requested review from benlangmuir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cachemeifyoucan @jansvoboda11